[MSHADE-124] keep original basedir after set d-r-p location to build dir - #128
[MSHADE-124] keep original basedir after set d-r-p location to build dir#128gzm55 wants to merge 2 commits into
Conversation
|
Resolve #496 |
1 similar comment
|
Resolve #496 |
|
@cstamas I wanted to refer my previous comment for this MR, I wanted to change the base location of dependency reduced pom. Can we check this MR and resolves issues if any. So my use-case here for this fix is to move the dependency-reduced-pom.xml to the target folder, the reason for this that I don't want my search results to include the values from this file. Target folder is excluded by default in IntelliJ and hence this helps |
|
@rmannibucau we can just add project.setOriginalModel(model); in this MR after project.setPomFile(dependencyReducedPomLocation); and it should be ready as well and work with maven4 |
|
@cstamas would it be possible to take this up? |
|
@gzm55 care to rebase? Thanks! |
|
Yes I can but I think I will have to create the MR again, since it is from a fork right? So the history would be lost? |
pr is rebased. |
|
@cstamas can we check this now? |
|
@cstamas would you be able to review and merge this change sometime this week? |
|
Hi @cstamas, just a gentle follow-up on this when you have a moment. Would really appreciate a review whenever you get the chance 🙂 |
|
@cstamas just following up on this PR, if there is anything we can do to get this merged? |
From maven 3.2.5, the pom and basedir are seperated (apache/maven@c15226f), and add new api `MavenProject::setPomFile()` to only upodate pom location. In this pr, the minimal maven version is bumped to 3.2.5, then use `setPomFile` to only update pom file location, leaving `${basedir}` unchanged.
d85430a to
3649d19
Compare
|
@cstamas @slawekjaranowski any updates on when this can be released? |
|
The fix looks right. One thing on the new IT guard. The lookbehind tests for The shared workflow's default This comment was created with AI assistance. |
|
For whoever picks this up: #827 and #828 propose a different fix for the same problem — saving Both of those are currently red, on the Windows cell only, for an unrelated path assumption in their own ITs — the same This comment was created with AI assistance. |
slachiewicz
added
the
waiting-for-feedback
6 participants
From maven 3.2.5, the pom and basedir are seperated
(apache/maven@c15226f),
and add new api
MavenProject::setPomFile()to only upodate pom location.In this pr, the minimal maven version is bumped to 3.2.5, then use
setPomFileto only update pom file location, leaving${basedir}unchanged.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MSHADE-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MSHADE-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.